Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoint: fix removed code comment. #29172

Merged
merged 1 commit into from
Nov 16, 2023
Merged

endpoint: fix removed code comment. #29172

merged 1 commit into from
Nov 16, 2023

Conversation

tommyp1ckles
Copy link
Contributor

@tommyp1ckles tommyp1ckles commented Nov 14, 2023 •
edited
Loading

Change in #27522 accidentally removed the first line in a code comment [1] explaining the significance of failure to get a mutex lock on an endpoint.

This undoes that change and fixes the comment.

[1] #27522 (comment)

@tommyp1ckles
endpoint: fix removed code comment.
3012b99 
Change in cilium#27522 accidentally
removed the first line in a code comment [1] explaining the significance of
failure to get a mutex lock on an endpoint.

This undoes that change and fixes the comment.

[1] cilium#27522 (comment)

Reported-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 14, 2023
@tommyp1ckles tommyp1ckles added the area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. label Nov 14, 2023
@tommyp1ckles tommyp1ckles marked this pull request as ready for review November 14, 2023 22:04
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner November 14, 2023 22:04
@tommyp1ckles tommyp1ckles mentioned this pull request Nov 14, 2023
Merged
tklauser
tklauser approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Nov 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2023
@tklauser
Copy link
Member

/test

@tklauser tklauser merged commit 57edd1c into cilium:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aditighag aditighag Awaiting requested review from aditighag aditighag is a code owner automatically assigned from cilium/endpoint

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommyp1ckles @tklauser