egressgateway: Use UID to identify CiliumEndpoints in epDataStore #29124
+97
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address a potential race condition demonstrated by a unit test added as part of this change, this changes internal type of the endpointID used to identify CiliumEndpoints in the EGW Manager's epDataStore from NamespacedName to UID. The race fixed by this change can be triggered during statefulset pod restart/migration to a different node, when a new endpoint may co-exist with the to-be-deleted endpoint with the same NamespacedName for a short period of time. To not break EGW Manager's endpoint event handling, these two need to have unique endpointID, which can be satisfied by relying on the UID. The drawback of using UID is incompatibility with CiliumEndpointSlices, which is however not an issue for the EGW, as it is already incompatible. In the future the EGW will probably move away from relying on CiliumEndpoints altogether, which should remove this limitation. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
rastislavs
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rastislavs
added
feature/egress-gateway
|
/test |
jibi
approved these changes
Nov 13, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address a potential race condition demonstrated by a unit test added as part of this change, this changes internal type of the
endpointIDused to identifyCiliumEndpoints in the EGW Manager'sepDataStorefromNamespacedNametoUID.The race fixed by this change may be triggered during statefulset pod restart/migration to a different node, when a new endpoint may co-exist with the to-be-deleted endpoint with the same
NamespacedNamefor a short period of time. To not break EGW Manager's endpoint event handling, these two need to have uniqueendpointID, which can be satisfied by relying on theUID.The drawback of using
UIDis incompatibility withCiliumEndpointSlices, which is however not an issue for the EGW, as it is already incompatible. In the future the EGW will probably move away from relying onCiliumEndpoints altogether, which should remove this limitation.