Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/allocator: store key in variable for error message #29076

Merged
merged 1 commit into from
Nov 9, 2023
Merged

pkg/allocator: store key in variable for error message #29076

merged 1 commit into from
Nov 9, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 9, 2023

In case of an error, the returned 'key' would have been nil. By storing it in a separate variable we will be able to return the error with a more descriptive message.

Fixes: e39fcae ("pkg/allocator: Improve 'Key allocation attempt failed' handling for CRD mode")

@aanm
pkg/allocator: store key in variable for error message
1c22d3f 
In case of an error, the returned 'key' would have been nil. By storing
it in a separate variable we will be able to return the error with a
more descriptive message.

Fixes: e39fcae ("pkg/allocator: Improve 'Key allocation attempt failed' handling for CRD mode")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added affects/v1.12 This issue affects v1.12 branch backport/author The backport will be carried out by the author of the PR. affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 9, 2023
@aanm aanm requested a review from a team as a code owner November 9, 2023 10:33
@aanm aanm requested a review from giorio94 November 9, 2023 10:33
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 9, 2023
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 9, 2023
@aanm aanm mentioned this pull request Nov 9, 2023
Merged
2 tasks
@aanm
Copy link
Member Author

aanm commented Nov 9, 2023

/test

@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 9, 2023
@aanm aanm merged commit ee6043d into cilium:main Nov 9, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
@aanm aanm mentioned this pull request Feb 2, 2024
Merged
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
affects/v1.12 This issue affects v1.12 branch backport/author The backport will be carried out by the author of the PR. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.14.4
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanm @giorio94 @julianwiedmann