bgpv1: Prevent multiple reconcilers with the same name #29071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
rastislavs
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rastislavs
force-pushed
the
bgp-reconciler-plumbing
branch
from
b01038f to
7311424
Compare
|
/test |
rastislavs
force-pushed
the
bgp-reconciler-plumbing
branch
2 times, most recently
from
cc6e2ad to
79f91e1
Compare
|
/test |
This change ensures that when multiple reconcilers with the same are passed to the BGPRouterManager, only the one with the highest priority is actually used for reconciliation. This prevents from corrupting data in the ReconcilerMetadata map (indexed by the reconciler name), and allows for overriding the reconcilers by a reconciler with the same name but higher priority. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
bgp-reconciler-plumbing
branch
from
79f91e1 to
7424fc2
Compare
|
/test |
rastislavs
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that when multiple reconcilers with the same are passed to the
BGPRouterManager, only the one with the highest priority is actually used for reconciliation.This prevents from corrupting data in the
ReconcilerMetadatamap (indexed by the reconciler name), and allows for overriding the reconcilers by a reconciler with the same name but higher priority.