Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: add back the sed command to update the logo path #28929

Merged
merged 1 commit into from
Nov 1, 2023
Merged

makefile: add back the sed command to update the logo path #28929

merged 1 commit into from
Nov 1, 2023

Conversation

bradwhitfield
Copy link
Contributor

Fixes: 44698df ("helm: simplify auto TLS annotations and various cleanup based on PR feedback")

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: 44698df

#27860 (comment)

The sed command was commented out and committed unintentionally. This changes fixes that so it will run again.

makefile: add back the sed command to update the logo path

@bradwhitfield
makefile: add back the sed command to update the logo path
89ae40c 
Fixes: 44698df ("helm: simplify auto TLS annotations and various cleanup based on PR feedback")

Signed-off-by: Brad Whitfield <bradswhitfield@gmail.com>
@bradwhitfield bradwhitfield requested review from a team as code owners November 1, 2023 16:06
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 1, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 1, 2023
@christarazi christarazi added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. area/build Anything to do with the build, more general than area/CI and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 1, 2023
@bradwhitfield bradwhitfield mentioned this pull request Nov 1, 2023
Merged
8 tasks
joestringer
joestringer approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up!

@joestringer joestringer merged commit fb996fa into cilium:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

@squeed squeed Awaiting requested review from squeed squeed is a code owner automatically assigned from cilium/helm

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general than area/CI area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradwhitfield @joestringer @christarazi