-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubble: Add Support for filtering on HTTP headers #28851
Conversation
7397e9a
to
5e78f23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this @ChrsMark. The error msg needs to be updated, but otherwise looks good to me.
5e78f23
to
7e40874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/test |
Hey @lambdanis @gandro ! Anything else missing here? |
Required pipeline ci-runtime seems to have timed out. I'm going to restart it. |
@ChrsMark the failing job has has its timeout bumped. I'm rebasing your PR and hopefully it all passes :-) |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: rohithsai1904 <rohithsai1904@gmail.com>
7e40874
to
12de0eb
Compare
/test |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Implements the server side changes for cilium/hubble#776
How to test this manually
make kind-image && make kind-install-cilium
(note thehubble-export-file-path
should be set for some weird reason that is not super clear to me, this is how the code flow works atcilium/daemon/cmd/hubble.go
Line 173 in f078737
cilium hubble enable --chart-directory=/home/chrismark/go/src/github.com/cilium/cilium/install/kubernetes/cilium
kubectl apply -f https://raw.githubusercontent.com/cilium/cilium/1.13.3/examples/minikube/sw_l3_l4_l7_policy.yaml
kubectl port-forward -n kube-system svc/hubble-relay --address 0.0.0.0 --address :: 4245:80
kubectl create -f https://raw.githubusercontent.com/cilium/cilium/1.13.3/examples/minikube/http-sw-app.yaml
. From https://docs.cilium.io/en/stable/gettingstarted/demo/#starwars-demo-> Build hubble CLI from cilium/hubble#1277 after replacing the
cilium
dependency in thego.mod
file withreplace github.com/cilium/cilium => /home/chrismark/go/src/github.com/cilium/cilium
../hubble observe --pod tiefighter --http-header Foo:bar -f
kubectl exec tiefighter -- curl -H "Foo: bar" -s -XPOST "http://deathstar.default.svc.cluster.local/v1/request-landing"
Oct 29 19:46:06.337: default/tiefighter:39348 (ID:49781) -> default/deathstar-7848d6c4d5-9z2wr:80 (ID:43688) http-request FORWARDED (HTTP/1.1 POST http://deathstar.default.svc.cluster.local/v1/request-landing)
kubectl exec tiefighter -- curl -H "Foo: baz" -s -XPOST "http://deathstar.default.svc.cluster.local/v1/request-landing"