Modularize kernel modules manager into its own cell #28713
Merged
+118
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
release-note/misc
pippolo84
force-pushed
the
pr/pippolo84/modules-manager-modularization
branch
4 times, most recently
from
a727ea8 to
6464caa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
force-pushed
the
pr/pippolo84/modules-manager-modularization
branch
from
6464caa to
09f6604
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
pippolo84
force-pushed
the
pr/pippolo84/modules-manager-modularization
branch
2 times, most recently
from
8ace98d to
1207e5d
Compare
|
@joamaki I've addressed the feedback regarding modules manager here. PTAL. |
joamaki
requested changes
Oct 24, 2023
pippolo84
force-pushed
the
pr/pippolo84/modules-manager-modularization
branch
from
1207e5d to
7ab5a00
Compare
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Modularize the kernel modules manager into its own cell. Instead of an exported Init() function, the manager stores the list of loaded modules once at startup. The tests are updated accordingly and since we are at it, migrate them from checkmate (the temporary wrapper for gopkg.in/check.v1) to the standard Go testing framework. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Kernel modules manager is meant to work with Linux kernel modules, so it belongs to the datapath/linux folder. CODEOWNERS file is updated accordingly. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/modules-manager-modularization
branch
from
7ab5a00 to
eab1ed7
Compare
joamaki
approved these changes
Oct 25, 2023
|
/test |
|
ci-clustermesh failure tracked here, rerunning |
dylandreimerink
approved these changes
Oct 26, 2023
|
@aditighag ping 🙏 |
aditighag
approved these changes
Oct 31, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modularize the kernel modules manager into its own cell.
Instead of exporting an Init() function, the manager stores the list of loaded modules once at startup.
The tests are updated accordingly and since we are at it, migrate them from checkmate (the temporary wrapper for gopkg.in/check.v1) to the standard Go testing framework.
This is a first step needed to modularize the iptables manager.