Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable WireGuard testing in multicluster workflow #18700

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

nbusseneau
Copy link
Member

Issue: #18699

As discussed during community meeting on 2022-02-02, we are disabling WireGuard testing on the multicluster conformance tests workflow until someone can look into it.

Issue: #18699

As discussed during community meeting on 2022-02-02, we are disabling
WireGuard testing on the multicluster conformance tests workflow until
someone can look into it.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Feb 3, 2022
@nbusseneau nbusseneau requested a review from gandro February 3, 2022 17:29
@nbusseneau nbusseneau requested review from a team as code owners February 3, 2022 17:29
@nbusseneau nbusseneau requested a review from aanm February 3, 2022 17:29
@maintainer-s-little-helper maintainer-s-little-helper bot assigned aanm and unassigned aanm Feb 3, 2022
@nbusseneau nbusseneau marked this pull request as draft February 3, 2022 17:35
@nbusseneau
Copy link
Member Author

Link to workflow run validating the changes (WireGuard steps were skipped): https://github.com/cilium/cilium/actions/runs/1790861628

Removing temporary test commit and marking as ready for review.

@nbusseneau nbusseneau force-pushed the pr/disable-multicluster-wireguard branch from 5001e1b to cb5b418 Compare February 4, 2022 17:28
@nbusseneau nbusseneau marked this pull request as ready for review February 4, 2022 17:31
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 7, 2022
@nbusseneau
Copy link
Member Author

This is a trivial change that does not require github-sec's approval, other reviews are in, CI has passed, marking as ready to merge.

@nbusseneau
Copy link
Member Author

After merge, we can re-enable the multicluster workflow.

@joamaki joamaki merged commit 2bd0850 into master Feb 8, 2022
@joamaki joamaki deleted the pr/disable-multicluster-wireguard branch February 8, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants