Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9 backports 2021-10-28 #17728

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Conversation

nebril
Copy link
Member

@nebril nebril commented Oct 28, 2021

Once this PR is merged, you can update the PR labels via:

$ for pr in 17511 17157 17708; do contrib/backporting/set-labels.py $pr done 1.9; done

or with

$ make add-label branch=v1.9 issues=17511,17157,17708

not included: #17470 @pchaigno

pchaigno and others added 4 commits October 28, 2021 11:27
[ upstream commit 54fdf6e ]

This new method will be used in the following commit to check if
tunneling is enabled from the node package.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit 7d58110 ]

Before this commit, if IPsec is enabled, we add all remote node IP
addresses to the ipcache of all nodes, regardless of whether
enable-remote-node-identity is true or false.

This commit reverts that behavior to only add those IP addresses if
remote-node identities, node encryption, or encryption+tunneling are
enabled. If encryption+native routing is enabled, we don't need to
expose the remote node IP addresses via the ipcache.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit 2cea16f ]

Wrap all the package dependencies in the Dockerfile.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit 7db6998 ]

Suppress warning message from helm:

warning: skipped value for l7Proxy: Not a table.

Signed-off-by: Chen Yaqi <chendotjs@gmail.com>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril requested a review from a team as a code owner October 28, 2021 09:30
@nebril nebril requested review from pchaigno and aditighag October 28, 2021 09:30
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.9 kind/backports This PR provides functionality previously merged into master. labels Oct 28, 2021
@pchaigno
Copy link
Member

not included: #17470 @pchaigno

@nebril 👍 You need to remove the PR reference from the pull request description though or its label will be updated when this is merged.

@nebril
Copy link
Member Author

nebril commented Oct 28, 2021

/test-backport-1.9

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR looks good. Thanks!

@nebril
Copy link
Member Author

nebril commented Oct 29, 2021

infra issue in 1.17, rerunning

@nebril
Copy link
Member Author

nebril commented Oct 29, 2021

test-1.17-5.4

Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my commit. Thanks!

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: Fix helm value when deploying pure ipvlan l3 mode #17708 -- docs: Fix helm value when deploying pure ipvlan l3 mode (@chendotjs)

Reviewed that PR as well 👍

@joestringer
Copy link
Member

GKE failure is a known issue (#17282), other tests are passing and it's been checked over by most of the original authors. Merging.

@joestringer joestringer merged commit 6e6a931 into cilium:v1.9 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants