[major] Drop input probes from spec. #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
force-pushed
the
feature/drop-input-probe
branch
from
21ec623 to
8c51d46
Compare
seldridge
approved these changes
Feb 22, 2024
|
Simple as. LGTM. |
mmaloney-sf
approved these changes
Feb 22, 2024
dtzSiFive
added a commit
to llvm/circt
that referenced
this pull request
May 9, 2024
Disallow input probes. cc chipsalliance/firrtl-spec#183 . Adds verifier for this, and mostly updates tests. Delete ProbeDCE. Many passes can (and should) be simplified as they do not need to consider this any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used in practice and have restrictions that they must be basically equivalent to a design that doesn't use them at all.