Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore BundleUpcastable #3487

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Restore BundleUpcastable #3487

merged 2 commits into from
Aug 16, 2023

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Aug 14, 2023 •
edited by jackkoenig
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation
  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Restore BundleUpcastable and deprecate it.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@sequencer sequencer requested a review from jackkoenig August 14, 2023 19:01
@sequencer sequencer added the Bugfix Fixes a bug, will be included in release notes label Aug 14, 2023
@sequencer sequencer added this to the 3.6.x milestone Aug 14, 2023
@sequencer sequencer force-pushed the fixBundleUpcastable branch from dc4383a to cd27496 Compare August 14, 2023 19:05
@sequencer sequencer changed the base branch from main to 3.6.x August 14, 2023 19:05
@sequencer sequencer changed the base branch from 3.6.x to main August 14, 2023 19:06
@sequencer sequencer force-pushed the fixBundleUpcastable branch from cd27496 to dc4383a Compare August 14, 2023 19:07
@sequencer sequencer modified the milestones: 3.6.x, 3.5.x Aug 14, 2023
@sequencer
Copy link
Member Author

I know it's bad to add it to 5.x and 6.x but it introduces the cross compile error for downstream projects.
I prefer re-adding it to Chisel main. After releasing 3.6.1, downstream projects which can bump to, the downstream projects can really see the warning(rather than a compile error). then I will remove it from downstream, and finally remove this API from 6.x.

@sequencer sequencer mentioned this pull request Aug 14, 2023
Closed
14 tasks
@jackkoenig jackkoenig changed the title Readd BundleUpcastable Restore BundleUpcastable Aug 16, 2023
@jackkoenig jackkoenig enabled auto-merge (squash) August 16, 2023 15:43
@jackkoenig jackkoenig merged commit b904c19 into main Aug 16, 2023
@jackkoenig jackkoenig deleted the fixBundleUpcastable branch August 16, 2023 16:19
@mergify mergify bot added the Backported This PR has been backported label Aug 16, 2023
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@sequencer @mergify
Restore BundleUpcastable (#3487)
f1d1a37 
(cherry picked from commit b904c19)

# Conflicts:
#	core/src/main/scala/chisel3/experimental/dataview/package.scala
@mergify mergify bot mentioned this pull request Aug 16, 2023
Open
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@sequencer @mergify
Restore BundleUpcastable (#3487)
b0c701d 
(cherry picked from commit b904c19)

# Conflicts:
#	core/src/main/scala/chisel3/experimental/dataview/package.scala
@mergify mergify bot mentioned this pull request Aug 16, 2023
Open
14 tasks
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@sequencer @mergify
Restore BundleUpcastable (#3487)
91a015b 
(cherry picked from commit b904c19)
@mergify mergify bot mentioned this pull request Aug 16, 2023
Merged
14 tasks
mergify bot added a commit that referenced this pull request Aug 16, 2023
@mergify @sequencer
Restore BundleUpcastable (#3487) (#3494)
2bdf35d 
(cherry picked from commit b904c19)

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@sequencer @jackkoenig