Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable argument extensions when in devcontainer #3409

Conversation

GeorgeLyon
Copy link
Contributor

@GeorgeLyon GeorgeLyon commented Jul 6, 2023

The additional-commandline-arguments functionality in Chisel does not work with the way Metals works for VSCode's TestExplorer UI, and as a result we have not been able to use VSCode's Test Explorer prior to this fix, which creates an environment variable to disable the command line argument extension functionality.

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Release Notes

  • VSCode's Metal's Test Explorer UI can now run tests when the CHISEL_ARGUMENT_EXTENSIONS environment variable is set to DISABLE

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@GeorgeLyon GeorgeLyon added the Internal Internal change, does not affect users, will be included in release notes label Jul 6, 2023
@GeorgeLyon GeorgeLyon merged commit 1d196ee into chipsalliance:main Jul 6, 2023
@GeorgeLyon GeorgeLyon deleted the dev/george/disable-argument-extensions branch July 6, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants