Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/my voyage resources page #95

Merged
merged 33 commits into from
Feb 29, 2024
Merged

Feature/my voyage resources page #95

merged 33 commits into from
Feb 29, 2024

Conversation

MattRueter
Copy link
Contributor

Description

Added resources page for 'My Voyage' where 'voyager' can view and add resources for current team.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MattRueter
create voyage-resources page skeleton.
7aea941
@MattRueter
create resource share input.
7db8641
@MattRueter
add SortingButton to resources page.
39a9ec0
@MattRueter
add ResourceCard component & clean up code in sibling files.
3b66ea9
@MattRueter
adjust style & layout of ResourceCard.
44fe9d6
@MattRueter
add fake data.
207d7f6
@MattRueter
add basic delete modal.
75d1a10
@MattRueter
add click handlers to ResourceCard trash can.
da9352a
@MattRueter
wrap form around deleteModal chidlren.
5bd3af8
@MattRueter
add test external link.
25c7bb7
@MattRueter
create rough draft view Modal.
d82a3af
@MattRueter
add modal toggle open/close to ResourceCard.
f858585
@MattRueter
move view and delete modals into separate files.
aa6c078
@MattRueter
adjust padding of Resource card information.
3d66ed4
@MattRueter
conditionally render trashcan if currentUser's resource.
224c844
@MattRueter
clean up code.
def9abc
@MattRueter
Merge branch 'dev' into feature/my-voyage-resources-page
21997b2
@MattRueter
Add banner images
4ae1897
@MattRueter
add EmptyBanner component.
7fd1ff9
@MattRueter MattRueter requested a review from Dan-Y-Ko as a code owner February 21, 2024 21:10
@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
chingu-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 11:13pm

Dan-Y-Ko
Dan-Y-Ko requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes are needed

  1. The sorting button should be link variant ( the one with newest/oldest text)
  2. In the resource card, there should be a vertical line between the shared by and the date
  3. The icon in the resource card should become the bolder version when user hovers over the entire card, not just that icon
  4. In the view confirmation modal, the "would you like to see this message again" should not have that background thing behind it
  5. The other sections for the background should have a border radius (same applies to delete modal)
  6. All of the text styles in the resource card needs to be checked again. Please refer to the figma for exact specifications needed
  7. The text styles in the view modal needs to be checked again (same applies to delete modal)
  8. If you do keep that modal section, define the prop types separately, don't inline it
  9. Follow how the modal has been implemented in this project and refactor your modals to fit that

@MattRueter
Copy link
Contributor Author

  • Those 7 style changes should now be fixed. I also noticed the 'EmptyBanner' was bit poor so I made some changes to that so it better matches the specs in the wireframe.
  • Modals have been refactored and added them to the Provider.

@Dan-Y-Ko Dan-Y-Ko self-requested a review February 29, 2024 23:15
Dan-Y-Ko
Dan-Y-Ko approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dan-Y-Ko Dan-Y-Ko merged commit 2332e0c into dev Feb 29, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the feature/my-voyage-resources-page branch February 29, 2024 23:15
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
@Dan-Y-Ko
Merge pull request #95 from chingu-x/feature/my-voyage-resources-page
8ead37e 
Feature/my voyage resources page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan-Y-Ko Dan-Y-Ko Dan-Y-Ko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattRueter @Dan-Y-Ko