-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature - top navigation refactor #83
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Drop Down menu: ‘Sign out’ is a button while the placeholder ‘Settings' is a link. I’ve tried to make them line up and look the same but on some browsers they may look slightly different. Storybook: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed:
- You're going to have to change how you look for a current voyage. You will need to look for the existence of an active property in the voyage status. It is in voyageteam.voyage.status.name and you're looking for Active status. Find method should work.
- The status should just be text, not a link.
- can you make the hover background thing on the nav items the same length as the status container and also add rounded corners. You can see it in the figma.
- We're gunna make a change in the designs. Removing the name and keeping the avatar and the arrow icon. In addition to that, can you add cursor pointer over it (should be over both the avatar and the icon).
- The avatar should be the user's actual avatar (grab from the redux store).
Sorry there's 1 more thing that needs fixing and I guess I didn't notice it before. Clicking inside the dropdown shouldn't close that dropdown menu, only if user clicks outside of it. The user can still click on the avatar/icon to close the menu though. Also keep in mind, you will need to implement this in a way where it can support closing of the dropdown menu automatically if user clicks on the notification bell (which will be implemented later) and any future things we might add in the top nav. You can actually try to just attach a dummy dropdown menu container to the notification bell now if you want to help you with this. Also if you want an example of what I'm talking about you can see the dropdown menus in trello, it's exactly same situation as we want for this app. |
I fixed the clicking inside of the DropDown menu. It now meets the following requirements.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
menu open with voyage story needs to be fixed
Viewing DropDown in Storybook now shows 1.closed, 2.open (with voyage) & 3.open (without voyage). We can also use controls if we wanted to try out different voyage names (longer, shorter, different format etc..) without the need to add fake data to the app's API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
feature - top navigation refactor
Description
Top navigation layout was messy and needed to be redone. Also navbar now has different states based on User authentication.
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: