Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing build in Vercel #73

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Fix failing build in Vercel #73

merged 3 commits into from
Dec 15, 2023

Conversation

Dan-Y-Ko
Copy link
Contributor

Description

There is a bug with a dependency in Storybook and older versions of Yarn. storybookjs/storybook#22431 Not exactly the same issue but it was the same idea. Solution was to just upgrade Yarn. The pnp thing modern Yarn uses was causing issues in this project so I set the node linker to node_modules format.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Build succeeds. Booted up the project locally to see if everything still works.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview Dec 15, 2023 7:51pm

@Dan-Y-Ko Dan-Y-Ko merged commit bb45db3 into dev Dec 15, 2023
2 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/vercel_build_fail branch December 15, 2023 22:45
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants