Skip to content

Discord Id not showing up in the directory #202

Closed
@cherylli

Description

Describe the bug
Discord id not showing up in the directory

To Reproduce Bug
Steps to reproduce the bug:

  1. Go to My Voyage
  2. Go to directory

Expected behavior
It should show up if they have their discord account connected via oauth. currently they don't so the display is correct. However, we will need to fix the backend to return users discord id in the team info endpoint (it is now stored in another table - userOAuthProfile)

Screenshots
image

Additional context
Add any other context about the problem here.

--------------- End of User Report: DO NOT MODIFY ITEMS BELOW THIS LINE ---------------

GitHub Issue No. / ID

Team Task
Here will be added Team declaration by Team Leads.

Development start date
Date when dev team start fixing a bug

Development end date
Date when dev team complete fixing a bug

BugFix Deploy Date
Date when BugFix is deployed, and Bug Issue is closed

PO Comment
Here will be PO team add a comment.

Activity

added and removed on Aug 23, 2024
cherylli

cherylli commented on Aug 24, 2024

@cherylli
Author

So I realized we have already updated the api response last week - but I'll need to also update the swagger sample response

this is how it looks like now, so frontend needs to update how it gets the discordID from the response. I will seed the dev database to populate jessica's discord oauth
image

Dan-Y-Ko

Dan-Y-Ko commented on Aug 24, 2024

@Dan-Y-Ko
Contributor

I'm guessing we use the providerUsername?

I didn't look at Swagger yet, I'm sure that will answer my question lol

cherylli

cherylli commented on Aug 25, 2024

@cherylli
Author

yeah it would be something like oauthProfile.find(provider.name==="discord").providerUsername

jdmedlock

jdmedlock commented on Aug 28, 2024

@jdmedlock
Contributor

DO NOT MODIFY/DELETE THIS COMMENT
Project task ID: 86b1v4mjw

self-assigned this
on Sep 8, 2024
linked a pull request that will close this issueFix/Show discordId #252on Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Discord Id not showing up in the directory · Issue #202 · chingu-x/chingu-dashboard