Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package.swift and perform needed move of swift source file #195

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Add package.swift and perform needed move of swift source file #195

merged 1 commit into from
Dec 13, 2019

Conversation

lvnkmn
Copy link
Contributor

@lvnkmn lvnkmn commented Sep 18, 2019 •
edited
Loading

regarding #194

  • tested and works in SPM (Xcode 11)
  • tested and still works in CocoaPods

@lvnkmn
Copy link
Contributor Author

lvnkmn commented Dec 13, 2019

Hi @chiahsien,
Is there any chance this will be merged at some point?

@chiahsien
Copy link
Owner

Sorry for the late reply, does it also work on latest Xcode?

@ksloginov
Copy link

ksloginov commented Dec 13, 2019 •
edited
Loading

It does! (I'm using this PR's version with Xcode 11.3. Works fine. Kudos to @lvnkmn !)

@chiahsien chiahsien merged commit 380d91c into chiahsien:develop Dec 13, 2019
@lvnkmn
Copy link
Contributor Author

lvnkmn commented Dec 13, 2019

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvnkmn @chiahsien @ksloginov