Swift 4.2 and Swift 5 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrote/rename in actual Swift - Add sectionInsetReference, similar to that of flow layout - Now use default itemWidth when itemSize.width is 0 - Restrict access level - Integrate other small patches
Works for Swift 5 and 4.2
- Using map instead of append is a + - Allocating new array instead of replacing old value one by one is a ?. Since columnHeights is unique reference, all modifications will be done in-place. However, there will be N + 1 checks which might be slow (or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the above changes can be migrated with Xcode. However, there is something you need to consider:
Behavior Change
Previously, all cells are "scale aspect fit" based on its ratio and available column width, and a cell will display if either height or width of the item size returned by delegate is ≤ 0. Now default
itemWidth(inSection:)will be used if item width returned by delegate is not valid.