Systemd service changes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to a system instead of a user service. In the general case (single user machine) we want this service to run from boot to shutdown, not only on user session. Using a user service forces users to enable lingering to achieve that. This change also removes the need for specific udev rules / plugdev group. - Enable more hardening options. - Add support for optional /etc/default/linux-thermaltake-rgb file (can contain DEBUG=true). - Add delay between restarts. - Change back executable path to the default /usr/bin. It is downstream packagers job to adapt the service file if they don't deploy to the standard location. Signed-off-by: Julien Nicoulaud <julien.nicoulaud@gmail.com>
nicoulaj
force-pushed
the
systemd-system-service
branch
from
8494ac5 to
6220cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a set of proposed changes regarding the systemd service:
/etc/default/linux-thermaltake-rgbfile (can containDEBUG=true)./usr/bin. It is downstream packagers job to adapt the service file if they don't deploy to the standard location.Some of these might be controversial, so open for discussion ;)