Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy moon upgrade to moonup update #14

Closed
chawyehsu opened this issue Aug 2, 2024 · 0 comments · Fixed by #23
Closed

Proxy moon upgrade to moonup update #14

chawyehsu opened this issue Aug 2, 2024 · 0 comments · Fixed by #23
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chawyehsu
Copy link
Owner

Since moonup can already be used to upgrade the toolchain, through the moonup update command. It should be good to intercept moon upgrade and proxy to moonup update to do the job of upgrading the toochain.

Running moon upgrade directly can break the shims created by moonup and eventually break the whole moonup installation. By implementing the interception, the problem can be avoided.

moonup update only upgrade the latest toolchain, which I believe should already matches the behavoir of moon upgrade, the interception should be implemented in moonup-shim.

@chawyehsu chawyehsu added enhancement New feature or request good first issue Good for newcomers labels Aug 2, 2024
chawyehsu added a commit that referenced this issue Oct 18, 2024
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant