Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing mitt.js in vue 3 instance of app #9596

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: Missing mitt.js in vue 3 instance of app #9596

merged 1 commit into from
Jun 5, 2024
+2 −1

Conversation

fayazara
Copy link
Contributor

@fayazara fayazara commented Jun 5, 2024

Pull Request Template

Description

Vue 3 instance of the pages missed the emitter initialization, this PR fixes this issue

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Sorry, something went wrong.

@fayazara fayazara requested a review from muhsin-k June 5, 2024 09:13
@fayazara fayazara self-assigned this Jun 5, 2024
@fayazara fayazara added frontend Involves working with javascript ( Vue JS / CSS ) Bug labels Jun 5, 2024
@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-9596 June 5, 2024 09:18 Inactive
@muhsin-k muhsin-k merged commit 88e4d9f into develop Jun 5, 2024
14 of 15 checks passed
@muhsin-k muhsin-k deleted the fix-missing-mitt-v3 branch June 5, 2024 09:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muhsin-k muhsin-k

Assignees

@fayazara fayazara

Labels
Bug frontend Involves working with javascript ( Vue JS / CSS )
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fayazara @muhsin-k @vishnu-narayanan