Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds the ability to disable the "new message notification" popup #9594

Merged
merged 11 commits into from
Jun 11, 2024
Merged

feat: Adds the ability to disable the "new message notification" popup #9594

merged 11 commits into from
Jun 11, 2024
+22 −2

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Jun 5, 2024

Pull Request Template

Description

This PR allows disabling the new message notification popup from the chatwootSettings config by adding showNotificationPopup: false. By default, the new message notification will be enabled.

Fixes https://linear.app/chatwoot/issue/CW-2834/is-there-a-way-to-disable-the-new-message-notification-popup

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Loom video
https://www.loom.com/share/6117020ea1b44166b77066ee69ffff53?sid=07138d1f-82c3-4e5e-b45b-2601b83ac5f4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sorry, something went wrong.

@linear Linear
Copy link

linear bot commented Jun 5, 2024

CW-2834 Is there a way to disable the "new message notification" popup?

@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9594 June 5, 2024 06:20 Inactive
muhsin-k
muhsin-k approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@muhsin-k muhsin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me except one minor comment. I have also verified it locally.
@iamsivin Please update the SDK docs after the merging the PR.

@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 5, 2024 09:17 Inactive
@iamsivin iamsivin requested a review from muhsin-k June 5, 2024 09:18
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 5, 2024 09:50 Inactive
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 5, 2024 10:31 Inactive
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 5, 2024 15:56 Inactive
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 7, 2024 02:30 Inactive
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 7, 2024 03:11 Inactive
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 7, 2024 04:15 Inactive
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9594 June 7, 2024 17:11 Inactive
pranavrajs
pranavrajs approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@pranavrajs pranavrajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, please merge it after testing.

@iamsivin
Copy link
Member Author

iamsivin commented Jun 7, 2024

Code looks fine, please merge it after testing.

@pranavrajs It's already tested by @muhsin-k

@iamsivin iamsivin merged commit 9689bbf into develop Jun 11, 2024
15 of 16 checks passed
@iamsivin iamsivin deleted the feat/CW-2834 branch June 11, 2024 02:44
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pranavrajs pranavrajs

@fayazara fayazara

@scmmishra scmmishra

@muhsin-k muhsin-k

Assignees

@muhsin-k muhsin-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamsivin @pranavrajs @muhsin-k @vishnu-narayanan