Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update cwctl to work with Ubuntu 24.04 LTS #9586

Merged
merged 5 commits into from
Jun 5, 2024
Merged

feat: update cwctl to work with Ubuntu 24.04 LTS #9586

merged 5 commits into from
Jun 5, 2024

Conversation

ajnadox
Copy link
Contributor

@ajnadox ajnadox commented Jun 3, 2024 •
edited by vishnu-narayanan
Loading

Pull Request Template

Description

Fixes #9570

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

André J added 3 commits June 3, 2024 21:26
Update setup_20.04.sh
52db94c
Update VERSION_CW
ea5d84a 
version was behind current 3.9.0
Update VERSION_CWCTL
c2658bc 
update to 2.8.0 since installation file was updated
@ajnadox ajnadox mentioned this pull request Jun 3, 2024
Closed
12 tasks
@vishnu-narayanan vishnu-narayanan changed the title updated installation to work with Ubuntu 24.04 LTS feat: update cwctl to work with Ubuntu 24.04 LTS Jun 5, 2024
@vishnu-narayanan
Copy link
Member

vishnu-narayanan commented Jun 5, 2024 •
edited
Loading

The add user utility was updated, and the --disabled-login behavior changed in Ubuntu 24.04. This set the login shell to /sbin/nologin, which broke the cwctl installation flow.

ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758

@vishnu-narayanan vishnu-narayanan merged commit c23e235 into chatwoot:develop Jun 5, 2024
11 of 12 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vishnu-narayanan vishnu-narayanan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

installation script on Ubuntu 24.04 LTS fails
2 participants
@ajnadox @vishnu-narayanan