Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace the bus events with emitter in widget #9584

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix: Replace the bus events with emitter in widget #9584

merged 3 commits into from
Jun 3, 2024
+12 −12

Conversation

fayazara
Copy link
Contributor

@fayazara fayazara commented Jun 3, 2024

Pull Request Template

Description

Fixes missing bus events which was breaking functionality on our widget

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added a wildcard listener and made sure all the events I noted are being triggered.

import mitt from 'mitt';
const emitter = mitt();
if (process.env.NODE_ENV === 'development') {
  emitter.on('*', (type, event) => {
    console.log(`Event emitted: ${type}`, event);
  });
}
export { emitter };

Sorry, something went wrong.

@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9584 June 3, 2024 10:11 Inactive
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9584 June 3, 2024 10:24 Inactive
@muhsin-k muhsin-k merged commit 00ef9c4 into develop Jun 3, 2024
14 of 15 checks passed
@muhsin-k muhsin-k deleted the fix-emitter-in-widget branch June 3, 2024 11:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muhsin-k muhsin-k

@scmmishra scmmishra

@iamsivin iamsivin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fayazara @muhsin-k @vishnu-narayanan