feat: add Google login flow and inbox creation #9580
Merged
+430
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a booboo, Microsoft concern was actually used in Microsoft::AuthorizationsController, which needed the OAuth client, let's bring it back
|
@muhsin-k can you review and test this? Revert the |
muhsin-k
reviewed
Jun 5, 2024
muhsin-k
approved these changes
Jun 6, 2024
|
@pranavrajs do you wanna take a peek at the code? This is tested on staging |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes
microsoft/callbacks_controllerto move common logic tooauth_callback_controller, most of the logic is re-used for GooglegoogleClientand I18n entries for Google loginjoinUrlutility along with specs (need to move it to utils)GoogleConcern,Google::AuthorizationsControllerandGoogle::CallbacksControllerPreview
CleanShot.2024-06-03.at.12.22.48.mp4
Linear Tickers
CW-3370
CW-3371