Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser info #9569

Merged
merged 1 commit into from
Jun 2, 2024
Merged

fix: browser info #9569

merged 1 commit into from
Jun 2, 2024

Conversation

s00d
Copy link
Contributor

@s00d s00d commented May 30, 2024

Pull Request Template

Description

fixed getting browser data

In Vue, without computed properties, the data doesn't update, and because of this, it doesn't display information about the browser.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pranavrajs pranavrajs requested review from iamsivin and scmmishra May 31, 2024 16:00
@pranavrajs
Copy link
Member

@s00d Thanks for the PR. @iamsivin @scmmishra Please take a look.

@scmmishra scmmishra merged commit 803471e into chatwoot:develop Jun 2, 2024
13 of 14 checks passed
@s00d s00d deleted the patch-4 branch June 3, 2024 06:30
Copy link

github-actions bot commented Jul 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants