Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reauthorization banner for Facebook #9553

Merged
merged 13 commits into from
May 30, 2024
Merged

feat: add reauthorization banner for Facebook #9553

merged 13 commits into from
May 30, 2024

Conversation

scmmishra
Copy link
Member

@scmmishra scmmishra commented May 27, 2024 •
edited
Loading

This PR has the following changes

  1. Use reauthorization_required as standard instead of inbox specific flags
  2. Show alert on the sidebar along with a tooltip for Microsoft and Facebook both
  3. Update facebook/Reauthorize.vue component to use the banner UI instead of the form
  4. Update alert icon layout on the sidebar to make it more prominent

Updated tooltip on the sidebar

CleanShot 2024-05-28 at 12 49 32@2x

Updated facebook page

CleanShot 2024-05-28 at 12 51 30@2x

@linear Linear
Copy link

linear bot commented May 27, 2024

CW-3288 Enable new Re-authorization flow for Facebook

@scmmishra scmmishra temporarily deployed to chatwoot-pr-9553 May 28, 2024 07:09 Inactive
@scmmishra scmmishra temporarily deployed to chatwoot-pr-9553 May 28, 2024 07:22 Inactive
@scmmishra scmmishra temporarily deployed to chatwoot-pr-9553 May 28, 2024 09:21 Inactive
@scmmishra scmmishra temporarily deployed to chatwoot-pr-9553 May 28, 2024 09:46 Inactive
@scmmishra scmmishra marked this pull request as ready for review May 28, 2024 15:02
@scmmishra scmmishra temporarily deployed to staging-chatwoot May 28, 2024 15:03 Inactive
@scmmishra scmmishra requested review from iamsivin, sojan-official and muhsin-k and removed request for iamsivin May 28, 2024 15:04
@scmmishra scmmishra temporarily deployed to chatwoot-pr-9553 May 29, 2024 14:56 Inactive
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9553 May 29, 2024 15:04 Inactive
muhsin-k
muhsin-k approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@muhsin-k muhsin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and reconnection is also working well.
CleanShot 2024-05-29 at 10 39 48@2x
CleanShot 2024-05-29 at 10 40 02@2x

@scmmishra scmmishra merged commit 6c682a6 into develop May 30, 2024
15 of 16 checks passed
@scmmishra scmmishra deleted the feature/cw-3288 branch May 30, 2024 04:11
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muhsin-k muhsin-k

@sojan-official sojan-official

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scmmishra @muhsin-k @vishnu-narayanan