Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Linear integration fixes #9538

Merged
merged 17 commits into from
May 29, 2024
Merged

chore: Linear integration fixes #9538

merged 17 commits into from
May 29, 2024

Conversation

muhsin-k
Copy link
Member

@muhsin-k muhsin-k commented May 24, 2024 •
edited
Loading

  • The order of status should be Backlog - Todo - In Progress - Done - Cancelled
  • The background for the linear card is quite off.
  • The title of the link on the Linear issue can be "Conversation (#{id}) with #{contact full name}"
  • Loader for unlink button
  • Clicking outside immediately close the modal, I lost the progress twice creating the Loom video.
  • Adding new line in description breaks issue create.
  • The submit button is not clickable if the screen is not big enough.

Fixes https://linear.app/chatwoot/issue/CW-3362/linear-integration-feedbacks

@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 24, 2024 11:33 Inactive
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 24, 2024 17:46 Inactive
@linear Linear
Copy link

linear bot commented May 27, 2024

CW-3362 Linear integration feedbacks

@muhsin-k muhsin-k self-assigned this May 27, 2024
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 27, 2024 10:52 Inactive
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 28, 2024 05:08 Inactive
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 28, 2024 05:55 Inactive
@muhsin-k muhsin-k marked this pull request as ready for review May 28, 2024 05:56
iamsivin
iamsivin reviewed May 28, 2024
View reviewed changes
Copy link
Member

@iamsivin iamsivin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhsin-k Could you please take a look at the comments?

@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 28, 2024 06:44 Inactive
@muhsin-k muhsin-k requested a review from iamsivin May 28, 2024 06:44
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 28, 2024 06:45 Inactive
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 28, 2024 08:40 Inactive
iamsivin
iamsivin reviewed May 28, 2024
View reviewed changes
Copy link
Member

@iamsivin iamsivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhsin-k LGTM, Added a comment. Please take a look.

@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9538 May 29, 2024 04:58 Inactive
@muhsin-k muhsin-k requested a review from iamsivin May 29, 2024 05:18
iamsivin
iamsivin approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@iamsivin iamsivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@muhsin-k muhsin-k merged commit a55fffa into develop May 29, 2024
15 checks passed
@muhsin-k muhsin-k deleted the chore/linear-review-fixes branch May 29, 2024 05:58
clairton pushed a commit to clairton/chatwoot that referenced this pull request Jun 13, 2024
@muhsin-k @clairton
chore: Linear integration fixes (chatwoot#9538)
8884a2e
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamsivin iamsivin

@pranavrajs pranavrajs

@fayazara fayazara

@scmmishra scmmishra

Assignees

@muhsin-k muhsin-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muhsin-k @pranavrajs @iamsivin @vishnu-narayanan