Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with Microsoft Provider #6702

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Fix issues with Microsoft Provider #6702

merged 4 commits into from
Mar 20, 2023

Conversation

Tarang
Copy link
Contributor

@Tarang Tarang commented Mar 19, 2023 •
edited
Loading

Pull Request Template

Description

The microsoft outlook inbox channel has issues:

  • Case sensitivity of the email
  • The lack of request for profile during the login step in the scope

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

We used this internally for a few weeks

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: draft label Mar 19, 2023
@netlify
Copy link

netlify bot commented Mar 19, 2023 •
edited
Loading

✅ Deploy Preview for chatwoot-storybook canceled.

Name Link
🔨 Latest commit 5991df2
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/6417feb86d6d6300081c7989

@Tarang Tarang marked this pull request as ready for review March 19, 2023 07:03
@tejaswinichile
Copy link
Contributor

Please fix the specs for Authorization Controller.
./spec/controllers/api/v1/accounts/microsoft/authorization_controller_spec.rb

@Tarang
Copy link
Contributor Author

Tarang commented Mar 20, 2023

Please fix the specs for Authorization Controller. ./spec/controllers/api/v1/accounts/microsoft/authorization_controller_spec.rb

It should pass tests now

tejaswinichile
tejaswinichile approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@tejaswinichile tejaswinichile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@tejaswinichile tejaswinichile merged commit 0c9f129 into chatwoot:develop Mar 20, 2023
@Tarang Tarang deleted the patch-1 branch March 22, 2023 02:04
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tejaswinichile tejaswinichile tejaswinichile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tarang @tejaswinichile