Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Article settings sidebar in new article page #5355

Merged
merged 6 commits into from
Aug 30, 2022
Merged

feat: Article settings sidebar in new article page #5355

merged 6 commits into from
Aug 30, 2022

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Aug 30, 2022 •
edited
Loading

Pull Request Template

Description

  • Adds articles settings sidebar in new articles page.
  • Fixes scroll bar issue.

Fixes https://github.com/chatwoot/product/issues/549

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Screencast
https://www.loom.com/share/2d79b7f2edec44919b75ca6f1596ba4f

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@iamsivin iamsivin closed this Aug 30, 2022
@iamsivin iamsivin reopened this Aug 30, 2022
@iamsivin iamsivin changed the title feat: Article settings sidebar in new article page feat: Disabled articles settings sidebar button in new article page Aug 30, 2022
@iamsivin iamsivin requested a review from nithindavid August 30, 2022 07:02
nithindavid
nithindavid previously approved these changes Aug 30, 2022
View reviewed changes
@iamsivin iamsivin requested a review from nithindavid August 30, 2022 08:39
@iamsivin iamsivin changed the title feat: Disabled articles settings sidebar button in new article page feat: Article settings sidebar in new article page Aug 30, 2022
@iamsivin iamsivin requested review from muhsin-k and nithindavid and removed request for nithindavid August 30, 2022 08:42
@iamsivin iamsivin merged commit d14beeb into develop Aug 30, 2022
@iamsivin iamsivin deleted the feat/new-article-settings-sidebar branch August 30, 2022 09:11
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nithindavid nithindavid nithindavid approved these changes

@muhsin-k muhsin-k Awaiting requested review from muhsin-k

Assignees

@nithindavid nithindavid

@iamsivin iamsivin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamsivin @nithindavid