Update .env.example #5180
Update .env.example #5180
Conversation
Added default database name config in example env file
|
@nikhilmuz Any context on why this was added would be helpful. There is already a default in the database.yml file. |
|
It would be helpful incase someone doesn’t walk through the codebase and
deploy multiple different instances of Chatwoot on a DB using production
docker image just having env file. One can just change sample env with
different DB name and extend production docker image
…On Wed, 3 Aug 2022 at 14:20, Pranav Raj S ***@***.***> wrote:
[image: Screenshot 2022-08-03 at 2 19 13 PM]
<https://user-images.githubusercontent.com/2246121/182566205-95ab5196-1b2b-4a2b-be3e-84439dc30a65.png>
@nikhilmuz <https://github.com/nikhilmuz> Any context on why this was
added would be helpful. There is already a default in the database.yml file.
—
Reply to this email directly, view it on GitHub
<#5180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZUYF7G67546Q73P2PMKB3VXIXEPANCNFSM55MLSJCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@nikhilmuz Unfortunately, this cannot be merged directly. The database name is different in different ENVs. A default on the sample env file might create confusion due to this case. Since we don't have the variable defined in the sample env, we can merge it with a small change. Let me know if the change works. |
Co-authored-by: Pranav Raj S <pranav@chatwoot.com>
|
Yes, the change works. I had a hard time changing the DB parameters for the name yesterday and had to dig deeper into ruby code to figure out the same so at least having params in sample .env makes sense. And for my case, the DB name which I got was as committed but now I realised that's different on different builds. Anyway, I have updated the same. |
|
@nikhilmuz Sure, makes sense. Thanks for the contribution. ❤️ |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Added default database name config in example env file
Type of change
How Has This Been Tested?
Fixed non-breaking documentation file so it won't affect the working of the codebase.
Checklist: