Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update ruby and docker base image to 3.0.4 #4693

Merged
merged 12 commits into from
May 27, 2022
Merged

chore: Update ruby and docker base image to 3.0.4 #4693

merged 12 commits into from
May 27, 2022

Conversation

vishnu-narayanan
Copy link
Member

@vishnu-narayanan vishnu-narayanan commented May 17, 2022 •
edited
Loading

Pull Request Template

Description

  • Update ruby to the latest stable patch version 3.0.4
  • Update the docker base image to resolve security issues reported by synk

Fixes #4658

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • tests on circle ci
  • CE edition tests via gh action
  • docker image builds via docker hub CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: draft label May 17, 2022
@vishnu-narayanan vishnu-narayanan changed the title chore: Update ruby version to 3.0.4 chore: Update ruby and docker base image to 3.0.4 May 17, 2022
@vishnu-narayanan vishnu-narayanan self-assigned this May 17, 2022
@vishnu-narayanan vishnu-narayanan marked this pull request as ready for review May 18, 2022 07:32
vishnu-narayanan added a commit to chatwoot/docs that referenced this pull request May 18, 2022
@vishnu-narayanan
chore: update ruby version to 3.0.2
e1fa237 
ref: chatwoot/chatwoot#4693
vishnu-narayanan added a commit to chatwoot/docs that referenced this pull request May 18, 2022
@vishnu-narayanan
chore: update ruby version to 3.0.4
2e169b2 
ref: chatwoot/chatwoot#4693
@vishnu-narayanan vishnu-narayanan mentioned this pull request May 18, 2022
Merged
@vishnu-narayanan
Copy link
Member Author

@sojan-official Updating ruby to 3.1.2is causing issues with google-protobuf package.

@pranavrajs
Copy link
Member

@vishnu-narayanan Why don't take it in steps? Upgrade to 3.0.4 so that the security issue is fixed and 3.1.2 later.

@vishnu-narayanan
Copy link
Member Author

@pranavrajs 3.0.4 was failing with https://hub.docker.com/repository/registry-1.docker.io/chatwoot/chatwoot/builds/e03d7dfd-2a3a-4c75-a91c-3302c22dc131.

So

  1. Wanted to verify if this error existed in 3.1.2.
  2. Since we are spending the effort to upgrade, it would have been efficient to do it once. 😓 No luck here though.

cc: @sojan-official

@sojan-official
Copy link
Member

@vishnu-narayanan should we try upgrading node?
FrontendMasters/fullstack-graphql#9

@sojan-official sojan-official mentioned this pull request May 24, 2022
Closed
@vishnu-narayanan vishnu-narayanan merged commit 568c30e into develop May 27, 2022
@vishnu-narayanan vishnu-narayanan deleted the chore/update_ruby_version branch May 27, 2022 12:03
@pr-triage pr-triage bot added the PR: merged label May 27, 2022
vishnu-narayanan added a commit to chatwoot/docs that referenced this pull request Jun 15, 2022
@vishnu-narayanan
chore: update ruby version to 3.0.4 (#276)
a0ea818 
ref: chatwoot/chatwoot#4693
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pranavrajs pranavrajs pranavrajs left review comments

Assignees

@vishnu-narayanan vishnu-narayanan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix security issues in docker images
3 participants
@vishnu-narayanan @pranavrajs @sojan-official