Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide non-minimized dist CSS file #506

Closed
mitar opened this issue Nov 5, 2015 · 4 comments
Closed

Provide non-minimized dist CSS file #506

mitar opened this issue Nov 5, 2015 · 4 comments
Milestone

Comments

@mitar
Copy link

mitar commented Nov 5, 2015

There is non-minimized js file, but not CSS file. This makes it hard to include it into systems like Meteor which does its own minimization in production, but during development you get nice non-minimized CSS.

@archinal
Copy link

Hey @mitar , if it's helpful for you, the project does include its un-minified SCSS here, which is then used to produce the minified CSS.

I would argue that it would be a bit of a mistake to provide the un-minified CSS as it is the SCSS which is developed and maintained, not the CSS (so if you were to do some great work with the styles, it would be way more helpful to submit a pull request for the SCSS than for a new and unmaintained CSS file).

@mitar
Copy link
Author

mitar commented Nov 16, 2015

Of course, this is why CSS would be in dist directory, make it clear it is an output. Pull requests should be still against SCSS, of course. You write that also in the readme or contribution guide. But providing CSS allows one to directly use it in websites, and have debugging to understand where something is happening.

@gionkunz
Copy link
Collaborator

We can include that within the next build

@gionkunz gionkunz added this to the 0.9.6 milestone Dec 22, 2015
@mitar
Copy link
Author

mitar commented Jan 24, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants