fix(Last Saved): Translate the "last saved" relative date message #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justjustifyjudge
approved these changes
Nov 19, 2024
ntoniazzi
force-pushed
the
translate-last-saved
branch
from
80b2b3d to
c9b0add
Compare
guyb1
force-pushed
the
translate-last-saved
branch
from
c9b0add to
c1c40e2
Compare
|
Hi @ntoniazzi, Thank you for your help with this! This was something that had been bugging me too 😂. I agree that maintaining two locale lists isn’t ideal, but it works as a temporary solution until we refactor that area. For now, I’ve added some code to dynamically import based on the selected language to avoid increasing the bundle size. Thanks again for your contribution - it’s much appreciated! |
guyb1
changed the title
guyb1
changed the title
guyb1
changed the title
guyb1
added a commit
that referenced
this pull request
Nov 27, 2024
* Translate the "last saved" relative date message * dynamic import locale base on the selected lang --------- Co-authored-by: Guy Ben-Aharon <guybenah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the top-navbar, the message indicating the date the diagram was last saved at is not translated. In English, we can see "Last saved 2 days ago". In Russian: "Последнее сохранение 2 days go".
I updated last-saved.tsx because it was straightforward, but it's not ideal because we have to maintain 2 locale lists: one here and the second in i18n.ts.