Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated color options of the ci report, include bootstrap failed #1430

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Updated color options of the ci report, include bootstrap failed #1430

merged 1 commit into from
Sep 27, 2023

Conversation

addyess
Copy link
Member

@addyess addyess commented Sep 22, 2023

  • the color palette now is a more inclusive for Color Blindness
  • Rather than use specific CSS styles for each icon, use a well defined css type
  • Provides a color key at the page header
  • Hover text now specifies which stage the test failed in
  • distinguishes between deploy failed from juju bootstrap failure
  • fixes bug where we relied on the alphabetical order of the words "False", "Timedout" and "True" to indicate whether a test or deployment failed, timedout or passed (by pulling the metadata.json for each job rather than using the presence of a file named deploy-result-*)

@addyess addyess force-pushed the akd/deployment-details-ci-report branch from 35a8643 to 8c405a8 Compare September 25, 2023 18:49
@kwmonroe kwmonroe merged commit a59a2c9 into main Sep 27, 2023
@kwmonroe kwmonroe deleted the akd/deployment-details-ci-report branch September 27, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @kwmonroe