Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check defaultShell dependency #360

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: Check defaultShell dependency #360

merged 1 commit into from
Aug 23, 2023

Conversation

braheezy
Copy link
Contributor

Closes #359

There were already OS-specific files defining a sane shell to use so ensureDependencies uses that instead of hardcoding bash for all platforms.

maaslalani
maaslalani approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@maaslalani maaslalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@stjohnfinn
Copy link

LGTM!!

@maaslalani maaslalani merged commit 45c0d59 into charmbracelet:main Aug 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaslalani maaslalani maaslalani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't require Bash on Windows
3 participants
@braheezy @stjohnfinn @maaslalani