Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VeilBlade AKA Restored Ritual Blade recipes book requirements #270

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

DamienRoyan
Copy link
Contributor

@DamienRoyan DamienRoyan commented Aug 9, 2022

Summary:
Change VeilBlade recipe to require both Oaths to The Chalice AND Sanguine Codex

Purpose of Change:
In the Blade Purification quest, the Hermit says that:

The main things you will need are His sacred word, Oaths to The Chalice. You'll also need to consult Sanguine Codex to decipher the original spell.

However the recipe "Restored Ritual Blade" requires Oaths to The Chalice OR Sanguine Codex, contradicting the Hermits words of needing both

Solution:
Make the two books seperate requirements for the recipe rather than substitutes for each other

Also the book "book_syncretism" which is the A Story in Shadow is nowhere mentioned by the hermit. If this is still a valid book, I'll add it back in if you want me to.

Alternatives considered:
The hermit lied to me :(

Make Veilblade need BOTH Oaths to the Chalice AND Sanguine Codex
@chaosvolt
Copy link
Owner

Either option works I suppose, hmm. And another instance where I have to fix the other version myself too. :V

I might take a second follow-up look at this tomorrow and decide whether I'd prefer it be restricted to specific books or be an either/or situation, and if so I might want to adjust the booklearns too. For now though...

@chaosvolt chaosvolt merged commit 4b41cad into chaosvolt:master Aug 9, 2022
chaosvolt added a commit that referenced this pull request Aug 9, 2022
Because #270 only fixed DDA version. :V
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants