Remove the blue color workaround for Windows #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/ The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions.
|
@sindresorhus |
|
@sindresorhus |
|
Have they also fixed the dim issue entirely? If so then let's remove the simple windows term check entirely as @be5invis mentioned. |
Seems so from the comments above. I'll do that in a separate PR. |
sindresorhus
added a commit
that referenced
this pull request
Mar 12, 2019
See: #330 It seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as the output is not predictable.
Not interested in supporting older builds. This workaround complicates a lot of code. Users can easily upgrade to latest Windows builds. |
sindresorhus
added a commit
that referenced
this pull request
Mar 12, 2019
See: #330 The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
marado
added a commit
to marado/chalk
that referenced
this pull request
Jun 30, 2019
Since chalk#330 was merged, the blue workaround for windows no longer exists, so let's remove an indication about that on the README.
billsedison
pushed a commit
to tc-cargo-net/chalk
that referenced
this pull request
Jul 22, 2019
…ve dim style workaround for Windows (#331)</cargo> See: chalk/chalk#330 The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
This was referenced Dec 7, 2019
Methuselah96
added a commit
to Methuselah96/chalk
that referenced
this pull request
Aug 29, 2021
The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/ The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions. Fixes chalk#329
Methuselah96
added a commit
to Methuselah96/chalk
that referenced
this pull request
Aug 29, 2021
See: chalk#330 The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
ionisaligox72
added a commit
to ionisaligox72/chalk
that referenced
this pull request
Aug 7, 2024
See: chalk/chalk#330 The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
EVINADAPCIPvb
added a commit
to EVINADAPCIPvb/chalk
that referenced
this pull request
Aug 25, 2024
See: chalk/chalk#330 The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/
The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions.
Fixes #329