Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some color types #360

Closed
Qix- opened this issue Aug 27, 2019 · 3 comments · Fixed by #433
Closed

Remove some color types #360

Qix- opened this issue Aug 27, 2019 · 3 comments · Fixed by #433

Comments

@Qix-
Copy link
Member

Qix- commented Aug 27, 2019

HCG was added after color-convert was added to ansi-styles. We should officially support it in ansi-styles and document its support here. It's similar to HSL and is (slowly) increasing in popularity.
@Qix- Qix- mentioned this issue Aug 27, 2019
Merged
@sindresorhus
Copy link
Member

I would honestly rather remove some colors than add more. In hindsight, we should IMHO, only have added rgb, hex, and hsl. Everything else is just bloat that very few use. Each added color space adds mental overhead for the user, noisy auto-complete, etc. So no, I don't think we should add a color space that almost no one uses. We can reconsider if it gets added to the CSS spec. That's usually a good sign of it becoming mainstream.

@Qix-
Copy link
Member Author

Qix- commented Aug 27, 2019 •
edited
Loading

We can reconsider if it gets added to the CSS spec.

That's a good litmus, then. We should extract those conversion methods, then, instead of including color-convert in its entirety.

@sindresorhus
Copy link
Member

@Qix- 👍

@sindresorhus sindresorhus changed the title Support HCG Remove some color types Sep 22, 2019
@sindresorhus sindresorhus mentioned this issue Sep 22, 2019
Merged
@sindresorhus sindresorhus mentioned this issue Apr 17, 2021
Merged
@Richienb Richienb mentioned this issue Apr 22, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add overline style and remove keyword, hsl, hsv, hwb and ansi color spaces Richienb/chalk
2 participants
@sindresorhus @Qix-