refactor(cli): store material info in crafting state #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
commented
Jan 8, 2025
| @@ -89,7 +89,9 @@ func newAttestationAddCmd() *cobra.Command { | |||
| // optimistic locking. We retry the operation if the state has changed since we last read it. | |||
| return runWithBackoffRetry( | |||
| func() error { | |||
| if err := a.Run(cmd.Context(), attestationID, name, value, kind, annotations); err != nil { | |||
| // TODO: take the material output and show render it | |||
| _, err := a.Run(cmd.Context(), attestationID, name, value, kind, annotations) | |||
There was a problem hiding this comment.
this is the entrypoint that can help with implementing showing the material in the CLI
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
jiparis
reviewed
Jan 9, 2025
| @@ -206,7 +206,7 @@ func (m *Attestation_Material) CraftingStateToIntotoDescriptor(name string) (*in | |||
|
|
|||
| // string materials don't have an artifact nor container, so a name is not available. | |||
There was a problem hiding this comment.
This probably is not true anymore. If the ID is outside the artifact, string materials would have an ID as well, right?
There was a problem hiding this comment.
not sure, since it's taking about name, ... let me double check
jiparis
approved these changes
Jan 9, 2025
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is that
attestation addcmd now has available structured information of the material that was added, so then it can be rendered as part of #1686To achieve that, we needed to update the underlying crafting state so the materials now can contain all its properties, as well as the identifier, as well as factoring out the material stateAPI->action translation code so it can be used outside of
statuscommand.cc/ @Horiodino