Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(materials): support zipped junit XML files #1640

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Dec 10, 2024

This PR adds support for adding multiiple JUnit XML files as a single JUNIT_XML material. This way, the output of Surefire maven plugin can be directly zipped and added to a Chainloop attestation.

Closes #1625

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis requested review from migmartri and javirln December 10, 2024 13:37
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Copy link
Member

@javirln javirln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jiparis jiparis merged commit f9e224a into chainloop-dev:main Dec 11, 2024
13 checks passed
@jiparis jiparis deleted the 1625-junit branch December 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

surefire material type support
3 participants