chore(policies): decouple evaluations representation #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Sep 5, 2024
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
jiparis
commented
Sep 6, 2024
| @@ -209,30 +207,3 @@ func Craft(ctx context.Context, materialSchema *schemaapi.CraftingSchema_Materia | |||
|
|
|||
| return m, nil | |||
| } | |||
|
|
|||
| // LoadJSONBytes Extracts raw data in JSON format from different sources, i.e cue or yaml files | |||
| func LoadJSONBytes(rawData []byte, extension string) ([]byte, error) { | |||
There was a problem hiding this comment.
Moved to avoid import cycles
| @@ -189,6 +193,23 @@ func extractPredicate(statement *intoto.Statement, v *ProvenancePredicateV02) er | |||
| return nil | |||
| } | |||
|
|
|||
| func fixPolicyTypeField(statement *intoto.Statement) { | |||
There was a problem hiding this comment.
Needed to prevent marshaling errors with old, wrong attestations with enum (number) type field.
javirln
approved these changes
Sep 9, 2024
migmartri
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples Policy Evaluation representation in the different layers: crafting, render and attestation API.
Apart from the decoupling advantage, this change solves the different [de]serialization problem when dealing with protobuf and structpb representations, in particular with Enums and oneOfs.
Thanks to this change,
typefield in evaluations has been fixed.Note: I've added a fix in
extractPredicatemethod to be able to read old attestations with the wrongtypefield (int)