Fix for gh-226 #227
Merged
Fix for gh-226 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut of sync with the actual method signatures and a few typos. Added Angular build output cache folders to gitignore.
ch4mpy
reviewed
Aug 30, 2024
| @@ -1,6 +1,7 @@ | |||
| package com.c4_soft.springaddons.security.oidc.starter.reactive.resourceserver; | |||
|
|
|||
| import java.nio.charset.Charset; | |||
| import java.sql.Date; | |||
There was a problem hiding this comment.
I think we want java.util.Date here.
There was a problem hiding this comment.
Gotcha - good catch. IntelliJ auto import and I should have caught that while committing.
ch4mpy
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated some @param javadocs that had gotten out of sync with the actual method signatures and a few typos. Added Angular build output cache folders to gitignore.
Fixes #226.