This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LayerNorm and GroupNorm, also move rename BatchNorm file to Norm.
Unrelated question: I saw in the Treex's module, you defined module's properties as both class variables (dataclass style) and as
init
's parameters? What is the reason behind this? I though the point of dataclass-like attribute is to reduce the boilerplate in__init__
?