feat: default ControllerConfiguration apiVersion and kind in helm #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
release-note
ThatsMrTalbot
force-pushed
the
feat/helm-default-config-apiversion-and-kind
branch
from
5725f07 to
2d0d4bf
Compare
cert-manager-prow
bot
added
size/S
ThatsMrTalbot
force-pushed
the
feat/helm-default-config-apiversion-and-kind
branch
from
2d0d4bf to
1393dbb
Compare
inteon
reviewed
Jun 25, 2024
| @@ -1,6 +1,7 @@ | |||
| {{- if .Values.cainjector.config -}} | |||
| {{- $_ := .Values.cainjector.config.apiVersion | required ".Values.cainjector.config.apiVersion must be set !" -}} | |||
| {{- $_ := .Values.cainjector.config.kind | required ".Values.cainjector.config.kind must be set !" -}} | |||
| {{- $config := .Values.cainjector.config -}} | |||
There was a problem hiding this comment.
Could you add some comments in the values.yaml file about backwards compatibility etc?
There was a problem hiding this comment.
I've added a comment in the values.yaml for each config block describing the behaviour and how to pin to a version
ThatsMrTalbot
force-pushed
the
feat/helm-default-config-apiversion-and-kind
branch
from
1393dbb to
dcc44ef
Compare
cert-manager-prow
bot
added
size/M
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
ThatsMrTalbot
force-pushed
the
feat/helm-default-config-apiversion-and-kind
branch
from
dcc44ef to
e30ad68
Compare
|
Hey, thanks for writing this feature so quickly! For context, this is useful for #7121. I tested this with $ gh pr checkout 7126
$ make helm-chart
$ helm upgrade --install cert-manager _bin/helm/cert-manager --create-namespace --namespace cert-manager \
--set installCRDs=true \
--set config.enableGatewayAPI=true
$ kubectl get cm -n cert-manager cert-manager -oyaml
apiVersion: v1
data:
config.yaml: |
apiVersion: controller.config.cert-manager.io/v1alpha1
enableGatewayAPI: true
kind: ControllerConfigurationAll good! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
cert-manager-prow
bot
merged commit 1b9c02e
into
cert-manager:master
5 of 6 checks passed
|
/kind feature |
cert-manager-prow
bot
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
This makes it easier to configure cert-manager using Helm by defaulting config.apiVersion and config.kind.
For example, enabling gateway api goes from:
to:
Kind
feature
Release Note