Hi @peschmae. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Hey, thanks for sharing! I agree that the approach we went with in 1.15, which is to advise people to add to use --set extraArgs={...,--enable-gateway-api}, is far from ideal.

Nit: it looks like most Helm charts around use the typography enableGatewayAPI, what do you think?

Nit: it looks like most Helm charts around use the typography enableGatewayAPI, what do you think?

Didn't even think about checking that, but that's a good input. I'll adjust it.

I also realised I forgot to update the helm schema, will do that asap.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maelvls. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hey, during this morning's open standup I've learned that there is already a (somewhat hidden) way of doing exactly that with cert-manager 1.15:

helm upgrade -i ... \
  --set config.apiVersion="controller.config.cert-manager.io/v1alpha1" \
  --set config.kind="ControllerConfiguration" \
  --set config.enableGatewayAPI="true" \

This way of enabling Gateway API through Helm isn't documented in values.yaml, we should fix that. We also discussed that setting the apiVersion and kind should be automated by the Helm chart (they are mandatory for now, as seen in controller-config.yaml). But we haven't done that yet 😅

What do you think?

In 1.16 and above, you no longer have to pass --set config.apiVersion and --set config.kind (ref: #7126). To enable Gateway API in 1.16, you can run:

make helm-chart
helm upgrade --install cert-manager _bin/helm/cert-manager --create-namespace --namespace cert-manager \
  --set crds.enabled=true \
  --set config.enableGatewayAPI=true

The last missing bits would be to (1) document this clearly in values.yaml (cert-manager/website#1517), and (2) remove the "experimental" mentions as you already did.

PR needs rebase.

I propose to close this since the alternative solution works great. I've opened cert-manager/website#1517 to add this solution to the documentation.

Feel free to re-open if you feel that config.enableGatewayAPI isn't working for you @peschmae.