Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linters: unparam, tenv, loggercheck, forbidigo, predeclared, usestdlibvars, asasalint, goprintffuncname, ineffassign, nosprintfhostport and exportloopref #6973

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Fix linters: unparam, tenv, loggercheck, forbidigo, predeclared, usestdlibvars, asasalint, goprintffuncname, ineffassign, nosprintfhostport and exportloopref #6973

merged 11 commits into from
Apr 30, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Apr 29, 2024 •
edited
Loading

Similar to #6952 and #6972.
Fixes all found issues for the following linters and enables them as a restriction: unparam, tenv, loggercheck, forbidigo, predeclared, usestdlibvars, asasalint, goprintffuncname, ineffassign, nosprintfhostport and exportloopref.

Note for reviewer: each commit fixes one linter.

Kind

/kind cleanup

Release Note

NONE

inteon added 6 commits April 29, 2024 16:48
@inteon
fix loggercheck linter
d640448 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix usestdlibvars linter
b86af60 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix ineffassign linter
000e9ff 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix predeclared linter
24e47ff 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix goprintffuncname linter
ae2c598 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix asasalint linter
0306731 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2024
@inteon inteon force-pushed the fix_linters branch 2 times, most recently from afd1070 to 3a5423b Compare April 30, 2024 07:16
inteon added 2 commits April 30, 2024 10:01
@inteon
fix nosprintfhostport linter
16a344e 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix forbidigo linter
8ea7cbc 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon added 3 commits April 30, 2024 10:47
@inteon
fix unparam linter
dd4f5f4 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix tenv linter
6fc8034 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix exportloopref linter
f96d31e 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@ThatsMrTalbot
Copy link
Contributor

Lots of renaming, function signature changes - I have skimmed all the files and cant see any code smells, also all tests still passing.

Thanks for putting in the time getting all the linters set up, hopefully a bit of pain now to make development easier in the future.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@cert-manager-prow cert-manager-prow bot merged commit d7182f4 into cert-manager:master Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inteon @ThatsMrTalbot