Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily revert "Re-enable the Venafi TPP E2E tests" #3997

Merged
merged 1 commit into from
May 12, 2021
Merged

Temporarily revert "Re-enable the Venafi TPP E2E tests" #3997

merged 1 commit into from
May 12, 2021

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented May 12, 2021

Currently all Venafi e2e tests are failing, see TestGrid i.e here

This should be a very short term revert, so people's PRs can get tested & merged- we should investigate and revert this PR soon.

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2021
@irbekrm irbekrm force-pushed the temp_disable_tpp_tests branch from a218192 to bb2e1a6 Compare May 12, 2021 15:09
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 12, 2021
@irbekrm irbekrm added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels May 12, 2021
@jetstack-bot jetstack-bot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 12, 2021
@irbekrm irbekrm added the release-note-none Denotes a PR that doesn't merit a release note. label May 12, 2021
@jetstack-bot jetstack-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 12, 2021
@irbekrm
Temporarily revert "Re-enable the Venafi TPP E2E tests"
9d059a2 
These tests are currently failing- we should investigate and re-enable
them.

This reverts commit c769432.

Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm irbekrm force-pushed the temp_disable_tpp_tests branch from bb2e1a6 to 9d059a2 Compare May 12, 2021 15:11
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 12, 2021
wallrj
wallrj approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The tests can still be run manually using /test pull-cert-manager-e2e-v1-20-feature-issuers-venafi-tpp

See https://github.com/jetstack/testing/blob/ecc5cf9324e010f3fe225117ecd8536b6ec41673/config/jobs/cert-manager/cert-manager-presubmits.yaml#L445-L450

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
jakexks
jakexks approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, jakexks, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [irbekrm,jakexks,wallrj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jakexks
Copy link
Member

jakexks commented May 12, 2021

/retest

@jetstack-bot jetstack-bot merged commit 11bd87b into cert-manager:master May 12, 2021
@jetstack-bot jetstack-bot added this to the v1.4 milestone May 12, 2021
@irbekrm irbekrm deleted the temp_disable_tpp_tests branch May 12, 2021 15:33
@irbekrm irbekrm mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

@wallrj wallrj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@irbekrm @jetstack-bot @jakexks @wallrj