prefer assert(0) to exit(1) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a fatal error (unaligned memory etc.) is detected, jerasure should assert(3) instead of exit(3) to give a chance to the calling program to catch the exception and display a stack trace. Although it is possible for gdb to display the stack trace and break on exit, libraries are not usually expected to terminate the calling program in this way. Signed-off-by: Loic Dachary <loic@dachary.org>
It's not that uncommon to have path longer than 100 characters. Signed-off-by: Loic Dachary <loic@dachary.org>
Resolve compilation warnings about unused variables and function return values being ignored. Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
assigned If the gf_methods was not found, the test would silently succeed doing nothing. Check for existence and fail if it is not in the path. Signed-off-by: Loic Dachary <loic@dachary.org>
Add a test to run with make check to run encoder and decoder to make sure they work at least in one simple case. It is also useful as a documentation about how to use them. Signed-off-by: Loic Dachary <loic@dachary.org>
|
-x ${GF_METHODS} is more robust than which, indeed ;-) repushed. |
|
lgtm! |
kmgreen2
added a commit
that referenced
this pull request
Dec 16, 2014
Merging a set of commits from Loic: Use assert(0) to exit(1) and clean-up some of the test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a few minor cleanups (compilation warnings, make check tests)