-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in CreateStorageKey #168
Comments
@vedhavyas
|
I'm reverting the breaking change, keeping the metadata v13 make a release in a bit. Thank you! |
Sorry about this 🙏🏼 |
@vgeddes @vedhavyas I have fixed CreateStorageKey to be backward compatible. PR to make it backward compatible: #166 |
@vgeddes @vedhavyas @ThreeAndTwo PR: #169 adds comprehensive test cases for |
@vgeddes @ThreeAndTwo can you confirm if the regression is fixed with the PR above ? |
@vedhavyas The regression was already fixed via PR: #166 |
@vedhavyas @ParthDesai I tested it. CreateStorageKey is normal, but I find decimal have inaccurate for token. |
This may not be related to |
True. @ThreeAndTwo double check your type please. Its usually the case |
closing this since its confirmed to be fixed in latest patch. @ThreeAndTwo please open an new issue if the above mentioned decimal issue still exists. |
yeah, everything is ok, thx. |
We are users of GSRPC (and contributors too) in https://github.com/Snowfork/polkadot-ethereum. The new API for CreateStorageKey breaks compatibility. But it also includes a regression:
Suppose I have a single storage item 'MyPallet.Nonce'. It is a not a map or a double-map. However calling
types.CreateStorageKey(metadata, "MyPallet", "Nonce")
fails with:So to get it to work I have to pass
nil
like this, which is confusing, since Nonce is very certainly not a map:The text was updated successfully, but these errors were encountered: